Skip to content

feat(icon): remove modifiers from the API [SWC-1264] #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: spectrum-two
Choose a base branch
from
Open

feat(icon): remove modifiers from the API [SWC-1264] #4288

wants to merge 1 commit into from

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Oct 23, 2025 •
edited
Loading

Description

This update removes --mod-icon-* custom property hooks per SWC-1264, see also the RFC for extensible styling. Class selectors and variants remain unchanged; stories were refreshed to match the current API.

  • Remove all --mod-icon-* custom property hooks.
  • Reduces unnecessary re-mapping of custom properties in favor of using them directly

Breaking change: the --mod-icon-* override layer is removed. Consumers should set --spectrum-icon-* variables directly where customization as needed.

Related issue(s)

  • fixes SWC-1264

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes (or confirmed existing coverage is sufficient for styling-only changes).
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a GitHub Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are passing or approved

Validation steps

  • No visual or behavioral changes compared to the current spectrum-two baseline.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:

    • The pages render correctly, are accessible, and are responsive.

  2. If components have been modified, VRTs have been run on this branch:

    • VRTs have been run and looked at.
    • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT ready-for-review S2 Spectrum 2 labels Oct 23, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: de39bef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 14 packages
Name Type
@spectrum-css/alertdialog Major
@spectrum-css/asset Major
@spectrum-css/assetcard Major
@spectrum-css/assetlist Major
@spectrum-css/avatar Major
@spectrum-css/badge Major
@spectrum-css/breadcrumb Major
@spectrum-css/divider Major
@spectrum-css/icon Major
@spectrum-css/miller Major
@spectrum-css/page Major
@spectrum-css/well Major
@spectrum-css/bundle Patch
@spectrum-css/preview Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

📚 Branch preview

PR #4288 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4288/index.html.

@castastrophe castastrophe force-pushed the castastrophe/feat-icon-modifier-removal branch 2 times, most recently from c7d0b47 to 52241c4 Compare October 23, 2025 13:29
@castastrophe castastrophe self-assigned this Oct 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

File metrics

Summary

Total size: 1.41 MB*
✅ No change in file sizes

Package Size Minified Gzipped
alertbanner 6.06 KB 5.80 KB 1.33 KB
icon 12.18 KB 11.28 KB 1.49 KB
pickerbutton 8.03 KB 7.63 KB 1.39 KB
table 47.13 KB 44.91 KB 5.31 KB
tag 19.92 KB 19.04 KB 2.70 KB

File change details

alertbanner

Filename Head Minified Gzipped Compared to base
index.css 6.06 KB 5.80 KB 1.33 KB 🔴 ⬆ 0.01 KB
metadata.json 3.62 KB - - 🔴 ⬆ 0.01 KB

icon

Filename Head Minified Gzipped Compared to base
index.css 12.18 KB 11.28 KB 1.49 KB 🟢 ⬇ 0.57 KB
metadata.json 6.59 KB - - 🟢 ⬇ 0.27 KB

pickerbutton

Filename Head Minified Gzipped Compared to base
index.css 8.03 KB 7.63 KB 1.39 KB 🟢 ⬇ 0.07 KB
metadata.json 4.14 KB - - 🟢 ⬇ 0.06 KB

table

Filename Head Minified Gzipped Compared to base
index.css 47.13 KB 44.91 KB 5.31 KB 🟢 ⬇ 0.06 KB
metadata.json 22.04 KB - - 🟢 ⬇ 0.02 KB

tag

Filename Head Minified Gzipped Compared to base
index.css 19.92 KB 19.04 KB 2.70 KB 🟢 ⬇ 0.83 KB
metadata.json 10.04 KB - - 🟢 ⬇ 0.24 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the castastrophe/feat-icon-modifier-removal branch 4 times, most recently from 9b42ed8 to 2b3ff45 Compare October 23, 2025 15:19
@castastrophe castastrophe force-pushed the castastrophe/feat-icon-modifier-removal branch 2 times, most recently from eb322f4 to 945da3b Compare October 23, 2025 16:01
@castastrophe castastrophe force-pushed the spectrum-two branch 2 times, most recently from 86bc092 to 71a231f Compare October 27, 2025 15:25
@castastrophe castastrophe force-pushed the castastrophe/feat-icon-modifier-removal branch 2 times, most recently from 39723a2 to 841dca9 Compare October 27, 2025 17:49
@castastrophe castastrophe force-pushed the castastrophe/feat-icon-modifier-removal branch 7 times, most recently from ebf7a32 to 20888f4 Compare October 28, 2025 13:36
@castastrophe castastrophe added size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. ready-for-review labels Oct 28, 2025
@castastrophe castastrophe force-pushed the castastrophe/feat-icon-modifier-removal branch from 20888f4 to de39bef Compare October 28, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@castastrophe castastrophe

Labels

ready-for-review run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2 size-3 M ~18-30hrs; moderate effort or complexity, several work days needed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@castastrophe